Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Twitter logo to X on the home page. #9573

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Change Twitter logo to X on the home page. #9573

merged 1 commit into from
Jul 18, 2024

Conversation

Souvik-Cyclic
Copy link
Contributor

Closes #9572

Updates Twitter logo to X on the home page.

Testing

Navigate to any page, scroll to the bottom, and verify the footer.

Screenshot

Before:
old1

After:
cx1

@cdrini
Copy link
Collaborator

cdrini commented Jul 18, 2024

@benbdeitch would you be able to take a look at/test this one?

@benbdeitch
Copy link
Collaborator

Yeah, I'll review/test this one. It'll be a good chance to try out gitpod.

Copy link
Collaborator

@benbdeitch benbdeitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me! I pulled this up on Gitpod and it worked fine, even accounting for different screen resolutions.

@cdrini cdrini merged commit 44a46e2 into internetarchive:master Jul 18, 2024
4 checks passed
@Souvik-Cyclic Souvik-Cyclic deleted the changeTwittertoX branch July 19, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Twitter logo to X on the home page.
3 participants