Improve account validation test coverage #9543
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9542.
Feature. Adds more test cases to cover formatting checks for email and username fields in
realtime_account_validation.js
Technical
Very simple! Basically reused the existing password test structure, also removed an unnecessary check re:
required
class.Happy to add any further unit tests here that would be helpful as part of the same PR!
Testing
JavaScript
testsrealtime_account_validation.js
should now be 75%.Screenshot
Stakeholders
@cdrini