Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve account validation test coverage #9543

Conversation

rebecca-shoptaw
Copy link
Collaborator

@rebecca-shoptaw rebecca-shoptaw commented Jul 9, 2024

Closes #9542.

Feature. Adds more test cases to cover formatting checks for email and username fields in realtime_account_validation.js

Technical

Very simple! Basically reused the existing password test structure, also removed an unnecessary check re: required class.

Happy to add any further unit tests here that would be helpful as part of the same PR!

Testing

  1. Run the JavaScript tests
  2. All tests should pass, and the test coverage for realtime_account_validation.js should now be 75%.

Screenshot

Stakeholders

@cdrini

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.65%. Comparing base (1cd8f21) to head (f027411).
Report is 57 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9543      +/-   ##
==========================================
+ Coverage   16.17%   16.65%   +0.47%     
==========================================
  Files          90       90              
  Lines        4736     4786      +50     
  Branches      824      829       +5     
==========================================
+ Hits          766      797      +31     
- Misses       3453     3470      +17     
- Partials      517      519       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rebecca-shoptaw rebecca-shoptaw force-pushed the 9542/feature/improve-account-validation-test-coverage branch from 7ebbdbd to f027411 Compare July 15, 2024 17:36
@rebecca-shoptaw rebecca-shoptaw marked this pull request as ready for review July 15, 2024 17:37
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Lgtm 🥳

@cdrini cdrini merged commit 8f61937 into internetarchive:master Jul 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve test coverage for realtime validation
3 participants