Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don’t autoselect identifier for UUIDs #9524

Merged

Conversation

Freso
Copy link
Contributor

@Freso Freso commented Jul 5, 2024

Storygraph was previously the only known identifier using UUIDs, but BookBrainz and MusicBrainz have recently been added to the known identifiers too, and they both use UUIDs as well.

Closes #9503

fix

Technical

This simply removes the matching of UUIDs entirely.

Testing

Edit an author, paste in a UUID. Storygraph should not get automatically selected.

(I have not done any actual testing of this myself as I don’t have a working environment running OL.)

Screenshot

Stakeholders

@jimchamp

Storygraph was previously the only known identifier using UUIDs, but
BookBrainz and MusicBrainz have recently been added to the known
identifiers too, and they both use UUIDs as well.

This simply removes the matching of UUIDs entirely.

Fixes internetarchive#9503
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.14%. Comparing base (1cd8f21) to head (c9e42c0).
Report is 26 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9524      +/-   ##
==========================================
- Coverage   16.17%   16.14%   -0.04%     
==========================================
  Files          90       90              
  Lines        4736     4745       +9     
  Branches      824      827       +3     
==========================================
  Hits          766      766              
- Misses       3453     3460       +7     
- Partials      517      519       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Freso! Have confirmed that this works as expected in my local environment.

@jimchamp jimchamp merged commit 9f7257d into internetarchive:master Jul 12, 2024
4 checks passed
@Freso Freso deleted the freso/9503/fix/dont-autoselect-on-uuid branch July 13, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BookBrainz, MusicBrainz identifiers easily mislabeled as StoryGraph identifiers
3 participants