Permit librarians to move editions to a new work #9459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new local variable `is_librarian` which is then checked for in the call that decides whether to add the “-- Move to a new work” option in the Work move dropdown list. Fixes internetarchive#9235
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9235
fix
Technical
Adds a new page-local variable
is_librarianwhich is then checked for in the call that decides whether to add the “-- Move to a new work” option in the Work move dropdown list.Testing
NOTE: I have not run tests or manually tested this in a working environment, as I haven’t set one up (yet?), and the
pre-commithook failed due to an which seems unrelated to this PR.I didn’t find anywhere where the existing behaviour was tested in automated tests, and thus also haven’t edited or added any such tests.
Screenshot
Stakeholders
@seabelis