fix dismissible banners #9436
Merged
fix dismissible banners #9436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can be tested on http://ol-dev1.us.archive.org:1337/ |
scottbarnes
approved these changes
Jun 15, 2024
There was a problem hiding this comment.
LGTM.
Testing on http://ol-dev1.us.archive.org:1337/ sometimes took 30+ seconds for the banner to dismiss, but that seems to be some unrelated issue whereby the POST to /hide_banner takes a while.
I cherry-picked the commits from #9432 and applied them on top of this PR, in the local development environment, and everything works as expected both logged in and logged out, in terms of the banner disappear once the x is clicked, and also the preferences sticking.
mekarpeles
added
the
Patch Deployed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/internetarchive/openlibrary/pull/9432/files#r1641272516
Technical
Testing
Screenshot
Stakeholders