remove inline.js from head.html and footer.html #9177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
reviewed
May 22, 2024
There was a problem hiding this comment.
Lgtm! One comment. Can you test that our analytics events are working after the change on testing? You should see e.g. a 0.gif request in the networks panel.
I'm not sure how we can test service worker is still working; maybe try unregistering the service worker on chrome and load the page again to confirm it re-registers.
cdrini
added
the
Needs: Submitter Input
github-actions
bot
removed
the
Needs: Submitter Input
|
@cdrini I'm having trouble deploying this to testing, seems like merge conflicts. When you get a chance could you try putting it there for me (probably removing some other commits from testing) so I can check the service worker stuff? |
RayBB
added
Needs: Staff / Internal
|
@cdrini deployed to testing
|
cdrini
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9176
This gets ride of inline js from head.html and footer.html.
After this, the only place left is in Swagger but we're still figuring out what to do with that.
Technical
Nothing fancy, just moving the code to the corresponding places.
Testing
I've looked through the code and as far as I can tell, window.q is totally gone, so we can remove these last bits of inline JS in the header and footers. I tested this in part by adding an
alert()if there was anything added to inline js and browsed the site locally without ever finding such an instance.Screenshot
Stakeholders
@jimchamp since you've reviewed a few other of these.