Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add direct book providers #6585
Add direct book providers #6585
Changes from all commits
ec1909d
d65f95a
4731816
e8756ae
02f9ce0
4980134
feb72ee
cc1dbc5
eb4234c
77b1896
b8083fe
4e4b870
2268e53
54b5f91
5a2a980
7418b02
1d8fd6c
c1891d5
abaf398
2f9d60e
6298877
8961a53
84bdb7d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're a little torn on this wording; there are a few spots in the code where
providers
refers to a list ofAbstractBookProvider
, but here it instead refers to effectively a list ofAcquisition
. Do we want to change our data schema to refer to this asacquisitions
as well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow-up for a future issue/pr: make this work in carousels. E.g. when a Web Book appears in a carousel, it should also display the "read" button