Fix autocomplete results showing up on pageload #10491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
force-pushed
the
fix/auto-autocomplete-results
branch
from
4ad8cb7 to
51ef9b9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10491 +/- ##
==========================================
- Coverage 17.31% 17.27% -0.04%
==========================================
Files 87 87
Lines 4835 4845 +10
Branches 856 860 +4
==========================================
Hits 837 837
- Misses 3471 3477 +6
- Partials 527 531 +4 ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
the
Needs: Response
jimchamp
approved these changes
Feb 21, 2025
|
What is holding up this fix? The broken behavior is super annoying! |
|
This should've gone out earlier that's my bad. The deploy just finished and should be out now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10484
Closes #10485
Addendum to #10415 ; we only want to show the results if the user has focus in the search bar component.
Technical
Testing
https://testing.openlibrary.org/search?q=harry+potter&mode=everything does not auto-show the auto complete, but changing the search type selector does cause them to appear.
Screenshot
Stakeholders