Fix registration errors from xauthn #10402
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10035
Closes #10045
The errors in
get_login_error
need to be updated to includebad_email
,bad_password
https://github.com/internetarchive/openlibrary/blob/master/openlibrary/plugins/upstream/account.py#L64-L98
@jimchamp can you also investigate whether we may be able to add errors using the
add_flash_message
(some are currently hidden on the page) as per #10045 ?Technical
Testing
Screenshot
Stakeholders