add read stats in addition to borrows #10349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Historically, we've only counted borrowing stats and not access to open materials.
mekarpeles
commented
Jan 16, 2025
| @@ -158,6 +158,7 @@ def POST(self, key): # noqa: PLR0915 | |||
| response = lending.get_availability_of_ocaid(edition.ocaid) | |||
| availability = response[edition.ocaid] if response else {} | |||
| if availability and availability['status'] == 'open': | |||
| stats.increment('ol.reads.bookreader') | |||
There was a problem hiding this comment.
Suggested change
| stats.increment('ol.reads.bookreader') | |
| if not is_bot(): | |
| stats.increment('ol.reads.bookreader') |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Let's just make sure it doesn't break on testing and does record some stat on graphite [for read option and not other options like borrow] |
cdrini
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
We looked on ABC call; seems low risk. @scottbarnes notes we couldn't quite test this on testing since statsd calls are seemingly disabled there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, we've only counted borrowing stats and not access to open materials.
One line improvement to track how often open access materials are read from Open Library.