Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix unused else if for ruff upgrade #10336

Merged
merged 2 commits into from
Jan 22, 2025
Merged

fix unused else if for ruff upgrade #10336

merged 2 commits into from
Jan 22, 2025

Conversation

RayBB
Copy link
Collaborator

@RayBB RayBB commented Jan 14, 2025 •
edited
Loading

Needed for #10328

Fixes this issue detected by the ruff upgrade
image

Technical

That code was completely unused. I checked the git blame and it was added 14 years ago :)

Testing

Screenshot

Stakeholders

@RayBB RayBB added the Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. label Jan 14, 2025
@cdrini cdrini mentioned this pull request Jan 16, 2025
Open
@RayBB RayBB mentioned this pull request Jan 18, 2025
Open
cdrini
cdrini approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@cdrini cdrini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thank you @RayBB ! Not manually testing ; relying on the unit tests, and the way way the logic works here which seems unlikely to break things.

@cdrini cdrini merged commit 4ff15b7 into master Jan 22, 2025
7 checks passed
@cdrini cdrini deleted the fix/unused-else-if branch January 22, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hornc hornc hornc left review comments

@tfmorris tfmorris tfmorris left review comments

@cdrini cdrini cdrini approved these changes

Assignees

@cdrini cdrini

Labels
Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this.
Projects
Ray's Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RayBB @tfmorris @hornc @cdrini