Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Removes PT004 - Deprecated pytest rule can be safely removed #10211

Merged

Conversation

techy4shri
Copy link
Contributor

Closes #10196

[Refactor] Removes PT004 - Deprecated pytest rule can be safely removed

Technical

The PT004 rule, deprecated in Ruff, has been removed from the configuration across the repository. This involved updates to the pyproject.toml and any related Ruff ignore sections.

Testing

  1. Verified the repository runs Ruff checks successfully without PT004.
  2. Confirmed no errors or warnings are triggered due to PT004.

Screenshot

Ruff-Check-PT004

Stakeholders

@RayBB

@techy4shri
Copy link
Contributor Author

there were two issues related to dbm.ndbm and UnicodeDecodeError in detect_missing_i18n.py which I left out as they are not related to the issue, otherwise everything checks out.

Copy link
Collaborator

@RayBB RayBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job now we just need a merge from staff :)

@RayBB RayBB added the Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. label Dec 27, 2024
@cdrini cdrini merged commit 81681fb into internetarchive:master Dec 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Re-enable several disabled ruff rules
3 participants