Move Wayback-dedup module to heritrix-contrib #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…syMock to project dependency.
chnaged groupId to address duplicate groupId warning.
template string with placeholders. no hard-coded parameters.
allows turning gzip compression on/off. main for quick test.
metric failedCount, add missedCount and errorCount.
HQ modules: for method removed in Heritrix, API deprecated in httpclient WBM-dedup: fix NPE in FetchHistoryProcessor due to changed expectation.
lock httpclient version to 4.3.3 stated by heritrix-commons. have to exclude hadoop’s dependency on jets3t 0.9.0 as it pulls in httpcore 4.1.2. add easy mock 3.1 to heritrix-contrib.
(code commented out during update for httpclient 4.3.3)
rewrite WbmPersistLoadProcessorTest for JUnit 3. (also disable a test that depends on production CDX server)
nlevitt
added a commit
that referenced
this pull request
Aug 27, 2014
Move Wayback-dedup module to heritrix-contrib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this patch adds
WbmPersistLoadProcessor, a module for fetching recrawl info from Wayback CDX server.I rewrote it for
org.apache.httpcomponent/httpclient4.3.3 (required by heritrix-common) and junit 3. During rewrite, I found heritrix-contrib's hadoop dependency is pulling in older version of httpclient and JUnit 4. So this patch also adds dependency exclusions forjets3tandjunittohbase-clientto address this problem. (Noteheritrix-commonalso depends onjets3t0.5.0, which does not depend onhttpclient).