Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade maven-assembly-plugin to 3.3.0 to fix file permissions #414

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

ato
Copy link
Collaborator

@ato ato commented Jul 19, 2021

The old default version of maven-assembly-plugin generates packages
containing dangerous world writable files.

Before:

$ zipinfo dist/target/heritrix-3.4.0-SNAPSHOT-dist.zip | grep heritrix[^/]*.jar
-rwsrwsrwt  2.0 unx   677008 b- defN 21-Jul-19 15:12 heritrix-3.4.0-SNAPSHOT/lib/heritrix-engine-3.4.0-SNAPSHOT.jar
-rwsrwsrwt  2.0 unx   446139 b- defN 21-Jul-19 15:12 heritrix-3.4.0-SNAPSHOT/lib/heritrix-modules-3.4.0-SNAPSHOT.jar
-rwsrwsrwt  2.0 unx   148876 b- defN 21-Jul-19 15:12 heritrix-3.4.0-SNAPSHOT/lib/heritrix-commons-3.4.0-SNAPSHOT.jar

After:

$ zipinfo dist/target/heritrix-3.4.0-SNAPSHOT-dist.zip | grep heritrix[^/]*.jar
-rw-r--r--  2.0 unx   677008 b- defN 21-Jul-19 15:23 heritrix-3.4.0-SNAPSHOT/lib/heritrix-engine-3.4.0-SNAPSHOT.jar
-rw-r--r--  2.0 unx   446139 b- defN 21-Jul-19 15:23 heritrix-3.4.0-SNAPSHOT/lib/heritrix-modules-3.4.0-SNAPSHOT.jar
-rw-r--r--  2.0 unx   148877 b- defN 21-Jul-19 15:23 heritrix-3.4.0-SNAPSHOT/lib/heritrix-commons-3.4.0-SNAPSHOT.jar

Fixes #413

The old default version of maven-assembly-plugin generates packages
containing dangerous world writable files.

Fixes #413
@ato ato force-pushed the maven-assembly-plugin-3.3.0 branch from c06ebd5 to 0dfb119 Compare July 19, 2021 06:46
@ato ato changed the title Upgrade maven-assmebly-plugin to 3.3.0 to fix file permissions Upgrade maven-assembly-plugin to 3.3.0 to fix file permissions Jul 19, 2021
@ato ato merged commit ab19efa into master Jul 22, 2021
@ato ato deleted the maven-assembly-plugin-3.3.0 branch July 22, 2021 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distribution package has broken filesystem permissions
1 participant