Umbra - AMQPUrlReceiver.java receive urls via amqp and add to frontier, related changes #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmat produced by https://github.com/internetarchive/umbra and add to frontier
…ting infinite consumers
…eaders"), if any, in http request
…status; add default amqpUri; replace queueName setting with exchange and routingKey, which seem to be what are needed; avoid sending urls that were received from AMQP, and robots.txt urls; set content-type of amqp message to application/json, which umbra seems to need
| // "Note: all methods of this interface are invoked inside the Connection's | ||
| // thread. This means they a) should be non-blocking and generally do little | ||
| // work, b) must not call Channel or Connection methods, or a deadlock will | ||
| // ensue. One way of ensuring this is to use/subclass QueueingConsumer." |
There was a problem hiding this comment.
I think this is probably fine for the moment. Let's worry about optimizing when we identify a bottleneck clearly.
|
By and large this looks good to me. I still think we should also get this running under travis-ci or similar, that way we could to full round-trip tests with a rabbitmq server, but merging for now. |
eldondev
added a commit
that referenced
this pull request
Feb 6, 2014
Umbra - AMQPUrlReceiver.java receive urls via amqp and add to frontier, related changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.