JDK11 support: upgrade maven-surefire-plugin to 2.22.2 #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under JDK11 our old version of it throws ClassNotFoundExceptions when tests load some builtin classes like javax.transaction.xa.Xid. Fixes #266
|
Upgrading surefire seems to have broken the FetchHttp tests. I've been getting inconsistent test results from run to run with them locally due to a data race between the client and server threads. So this change is on hold until the FetchHttp tests are fixed. |
It seems older versions only matched *Test.java but the new version is now incorrectly including it.
ato
force-pushed
the
jdk11-upgrade-surefire
branch
from
bd87632 to
d3d19e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under JDK11 our old version of it throws ClassNotFoundExceptions when
tests load some builtin classes like javax.transaction.xa.Xid.
Fixes #266