fix some trough dedup bugs #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
especially this:
- writeUrlCache.remove("segmentId");
+ writeUrlCache.remove(segmentId);
and some improvements and tweaks
* master: replace System.err.println with logger.info Revert "Upgrade httpclient to 4.5.7 and handle cookies more compliantly" Removing outdated test. Disable questionalbe test. Avoid deprecated flag. Supply an iterator, for internetarchive#245 Updated POM to use latest version. Update README.md Handle missing closing paren in srcset descriptor Teach jericho extractor srcset Don't run srcset test against jericho, it doesn't handle it Handle commas more compliantly when parsing srcset Ensure we start parsing full lines, for internetarchive#239.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
especially this:
and some improvements and tweaks