namespace scope log logger to crawl job #226
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bad bug. Stupid, too. When multiple crawls are running with
DecideRuleSequence.logToFile
enabled, all the scope log lines from allthe crawls are going to all the scope logs for all the crawls. It was
because of this line:
logName
here is "scope" normally, for all crawl jobs.Logger
is shared across the whole java vm, soLogger.getLogger("scope.log")
returns the same logger for everycrawl job. Each time a crawl starts, it adds another output file to
the logger.
Fix is to give the logger a name specific to the crawl job.
😳🥵🥶💩