Set character set to UTF-8 when passing through files. #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlevitt
added a commit
that referenced
this pull request
Feb 11, 2015
Set character set to UTF-8 when passing through files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default character encoding for file in Java is UTF-8. Since Heritrix never overrides this when writing logs and reports those files are encoded in UTF-8.
The restlets, however, assume a default character encoding of iso-8861-1. This means that reports and logs are presented using the wrong character set when viewed through the Heritrix GUI.
Most of the time this isn't an issue as Heritrix mostly uses the basic ASCII character set. It can however be an issue for customized reports/logs.