Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce purl as a type and validating sxpdx and cycloneDX purl #33

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

kchetans
Copy link
Contributor

introduce purl as a type and validating sxpdx and cycloneDX purl

@kchetans kchetans added the enhancement New feature or request label Feb 11, 2023
@kchetans kchetans self-assigned this Feb 11, 2023
@kchetans kchetans linked an issue Feb 11, 2023 that may be closed by this pull request
riteshnoronha
riteshnoronha previously approved these changes Feb 14, 2023
Copy link
Contributor

@riteshnoronha riteshnoronha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the interface

added test case for purl inside component,cdx and spdx

merge code with master and fixed test cases for fake_component
Copy link
Collaborator

@surendrapathak surendrapathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riteshnoronha riteshnoronha merged commit 608b5b3 into main Feb 16, 2023
@surendrapathak surendrapathak deleted the feature/purl-type branch July 10, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PURL as a type
3 participants