Updated the Gateway Address Bug returning Silo Endpoint for Client #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice one - thank you! |
|
Yep was a pretty big bug I encountered great to see it merged |
|
Oh btw I have a generics based implementation for the PersistenceStorageProvider would you be amenable to a PR or at least a disccussion in an issue for that?? |
would be happy to see what you were thinking around this in a new issue - i had opted for a string to be stored in the marten state document so that the orleans serialiser can be used, rather than the marten one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Gateway Provider was returning the SiloAddress without any transformation this will cuase all Client request to go to the Silo Clustering Port instead of the gateway Port This PR fixes that