Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Implement attachment sending #869

Merged
merged 8 commits into from
Jun 19, 2022
Merged

feat!: Implement attachment sending #869

merged 8 commits into from
Jun 19, 2022

Conversation

EepyElvyra
Copy link
Contributor

About

this PR gives the ability to append already uploaded images to a message without reuploading it

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
    • (If existent):
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

interactions/api/models/channel.py Outdated Show resolved Hide resolved
interactions/api/models/member.py Outdated Show resolved Hide resolved
interactions/api/models/message.py Outdated Show resolved Hide resolved
interactions/api/models/webhook.py Outdated Show resolved Hide resolved
interactions/client/context.py Outdated Show resolved Hide resolved
EepyElvyra and others added 5 commits June 19, 2022 17:36
Co-authored-by: Sofia <41456914+ffl0w@users.noreply.github.com>
Co-authored-by: Sofia <41456914+ffl0w@users.noreply.github.com>
Co-authored-by: Sofia <41456914+ffl0w@users.noreply.github.com>
Co-authored-by: Sofia <41456914+ffl0w@users.noreply.github.com>
Co-authored-by: Sofia <41456914+ffl0w@users.noreply.github.com>
@EepyElvyra EepyElvyra enabled auto-merge (squash) June 19, 2022 15:36
@EepyElvyra EepyElvyra requested a review from i0bs June 19, 2022 15:36
@Toricane
Copy link
Contributor

Docs check failed

@EepyElvyra
Copy link
Contributor Author

Docs check failed

Fuck circular import..

…to_send_methods' into implement_attachments_attribute_to_send_methods
@EepyElvyra
Copy link
Contributor Author

Docs check failed

Fuck circular import..

Should be resolved now

Copy link
Contributor

@Toricane Toricane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EepyElvyra EepyElvyra merged commit c2b8cd6 into interactions-py:unstable Jun 19, 2022
@EepyElvyra EepyElvyra deleted the implement_attachments_attribute_to_send_methods branch June 19, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants