fix: make typehinting for Extension.bot work #1748
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
This PR makes the typehint for
Extension.bot
correct when using Pyright. For some reason, doingbot: Client
doesn't typehint the variable correctly in Pyright, and so this PR works around it by makingbot
andclient
properties with setters, which both makes it act like the old variable and also makes Pyright not complain... for some reason.Perhaps further investigation can be done to see just why the original issue occurs, but at least this PR hides the issue from the typical user.
Changes
Extension.bot
andExtension.client
properties with setters.Related Issues
#1747
Test Scenarios
Python Compatibility
3.10.x
3.11.x
Checklist
pre-commit
code linter over all edited files