Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly set responded in edit_origin #1704

Merged
merged 1 commit into from
Jun 25, 2024
Merged

fix: correctly set responded in edit_origin #1704

merged 1 commit into from
Jun 25, 2024

Conversation

ItsRqtl
Copy link
Contributor

@ItsRqtl ItsRqtl commented Jun 21, 2024

Pull Request Type

  • Feature addition
  • Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

Changes

Set self.responded to True on completion of edit_origin in ComponentContext

Related Issues

Test Scenarios

See https://discord.com/channels/789032594456576001/1253800406556082196

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

@ItsRqtl
fix: correctly set responded in edit_origin
1a99ddc 
Signed-off-by: Rqtl <itsrqtl@gmail.com>
AstreaTSS
AstreaTSS approved these changes Jun 22, 2024
View reviewed changes
Copy link
Member

@AstreaTSS AstreaTSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel confident we can slip this into 5.13.

@silasary silasary merged commit cf395d1 into interactions-py:unstable Jun 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AstreaTSS AstreaTSS AstreaTSS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ItsRqtl @AstreaTSS @silasary