Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: specify language_version to python 3.10 #1696

Merged

Conversation

AstreaTSS
Copy link
Member

@AstreaTSS AstreaTSS commented Jun 8, 2024

Pull Request Type

  • Feature addition
  • Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

This specifies a language version pre-commit so it uses Python 3.10. This is very useful if, say, your default Python installation is 3.8 (as it is on many Linux systems) and you used the 3.8 installation on the repo, as pre-commit would use that and make black fail on files with match.

Changes

  • Add default_language_version to pre-commit and set it to python: python3.10.
  • Add language: python to Ruff.

Related Issues

Test Scenarios

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

@AstreaTSS AstreaTSS changed the title ci: specify language_version for python 3.10 ci: specify language_version to python 3.10 Jun 8, 2024
@silasary silasary merged commit ebb420a into interactions-py:unstable Jun 16, 2024
2 checks passed
@AstreaTSS AstreaTSS deleted the language-version-pre-commit branch June 16, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants