fix: let unload_extension() pop regex pattern listeners #1683
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
This PR fixes an error while calling
Client.unload_extension()
due to the extension containing a callback (component or modal) that uses a regex pattern (re.Pattern
) listener.Changes
Extension.drop()
to allow for droppingre.Pattern
listeners, which are stored in a different dict insideClient
Related Issues
interactions.py Discord server help thread: https://discord.com/channels/789032594456576001/1240745583636119562
Test Scenarios
The command
/test-unload
should run without errors with the extension's command/test-a
unloaded. You may need to reload your Discord client (hotkey^R
) to refresh the list of commands.test.py
(main)test_ext.py
(extension)The command in this extension has two different component callbacks: a
str
one and are.Pattern
one.Python Compatibility
3.10.x
3.11.x
Checklist
pre-commit
code linter over all edited files