Task loop supports localized datetime from trigger #1656
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
Updated the
_task_loop
method fromTask
to allow the computation oftimeout|
on localizeddatetime
objects.The timeout computation would fail if
self.trigger.next_fire()
returned a localized object.Changes
Related Issues
Test Scenarios
BaseTrigger
.next_fire()
method to return a localized datetime object.This would fail prior to this commit, but now works.
Python Compatibility
3.10.x
3.11.x
Checklist
pre-commit
code linter over all edited files