Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support nitro basic PremiumType #1563

Merged
merged 4 commits into from
Nov 15, 2023

Conversation

Scrxtchy
Copy link
Contributor

Pull Request Type

  • Feature addition
  • Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

recieved this line in my terminal

Class `PremiumType` received an invalid and unexpected value `3`, a new enum item will be created to represent this value. Please update interactions.py or report this issue on GitHub - https://github.com/interactions-py/interactions.py/issues

Found it only a little odd it that this was missing for what was announced a year ago and they still don't sell it here, but since it's on the docs it wasn't hard to fix.

Changes

  • added Nitro Basic to the PremiumType enum value 3

Test Scenarios

No tests should be required with this enum change

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

@LordOfPolls LordOfPolls changed the base branch from stable to unstable October 29, 2023 04:02
Copy link
Member

@AstreaTSS AstreaTSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub's doing a weird diff for the pyproject.toml, but looks good otherwise.

@AstreaTSS AstreaTSS merged commit e5ef5c1 into interactions-py:unstable Nov 15, 2023
3 checks passed
@Scrxtchy Scrxtchy deleted the nitro-basic branch November 16, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants