feat: implement console ext #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 48.28% // Head: 48.22% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## 5.x #1287 +/- ##
==========================================
- Coverage 48.28% 48.22% -0.06%
==========================================
Files 136 137 +1
Lines 13779 13796 +17
==========================================
Hits 6653 6653
- Misses 7126 7143 +17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
silasary
reviewed
Feb 26, 2023
silasary
approved these changes
Feb 27, 2023
i0bs
reviewed
Feb 27, 2023
Co-authored-by: Sophia <41456914+i0bs@users.noreply.github.com>
i0bs
approved these changes
Feb 27, 2023
LordOfPolls
added a commit
that referenced
this pull request
Mar 13, 2023
* feat: implement console ext * style: linter pass * ci: correct from checks. * Update pyproject.toml Co-authored-by: Sophia <41456914+i0bs@users.noreply.github.com> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Sophia <41456914+i0bs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This PR adds a new extension called "console" to the builtin collection. The Console extension allows users to start the bot with the aiomonitor console active, which provides a REPL for the bot.
To access the console, users can connect to the port specified in the constructor (by default, port 501). On Linux, users can do this with nc localhost 501, while on Windows they can use telnet localhost 501. Alternatively, users can also use python -m aiomonitor.cli -p 501 on both platforms.
Checklist
pre-commitcode linter has been run over all edited files to ensure the code is linted.3.8.6and higher.versionadded,versionchangedanddeprecatedto any new or changed user-facing function I committed.Pull-Request specification
I've made this pull request: (check all that apply)
This is: