refactor(context): allow edit message from modal interaction #1245
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
There is known bug (or we just don't support this feature) when you can't edit message from the modal interaction.
This pr fixes this bug by:
ComponentContext.defer
to_Context.defer
and removingCommandContext.defer
. They are same butComponentContext
haveedit_origin
param. So now we can defer withedit_origin
for modal.CommandContext.edit
to make work with modals. Code partially copied fromComponentContext.edit
.Additionally:
with suppress(LibraryException)
instead of this cursed code:Checklist
pre-commit
code linter has been run over all edited files to ensure the code is linted.3.8.6
and higher.versionadded
,versionchanged
anddeprecated
to any new or changed user-facing function I committed.Pull-Request specification
I've made this pull request: (check all that apply)
This is: