Feature home assistant #85
Conversation
Merge from original repo
… been on for some time)
…ophone index initialization
…ble of the input word
Merging new home assistant features
| @@ -0,0 +1,326 @@ | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
Why is this file here? Should be in nodes or src (seems like this is a copy?)
There was a problem hiding this comment.
I have no clue about why this is here. I think this is a mistake. This file can be removed.
| while not rospy.is_shutdown() and not self.result: | ||
| self.rate.sleep() | ||
| assert self.result == True | ||
|
|
There was a problem hiding this comment.
I would add another test to verify the text received is the same as what is expected. All you need is another function with the test_ prefix. Note that the context will be reset between tests and setup will run again.
There was a problem hiding this comment.
Thank you for your suggestion! I was a bit stuck.
However, I have just found out that the code the code here for the stt service is not the same as the one in feature/edison-smarthome. I changed it a while ago because it was giving me "ERROR: Broken Pipe" when using the method transcribe_stream_request. So I followed the instruction on the google stt page to create a different method for a continuous stream from the mic.
TLDR: I cannot add another test since this stt service is not working (for me at least).
I can add a test if I change the stt service file to the one in feature/edison-smarthome, where there is a different method for handling a stream.
https://github.com/micolspitale93/HARMONI/blob/feature/edison-smarthome/harmoni_detectors/harmoni_stt/nodes/google_service.py
Co-authored-by: Michael Swan <10856729+RMichaelSwan@users.noreply.github.com>
Co-authored-by: Michael Swan <10856729+RMichaelSwan@users.noreply.github.com>
Co-authored-by: Michael Swan <10856729+RMichaelSwan@users.noreply.github.com>
…ale93/HARMONI into feature/home-assistant
|
The fixes are good. Unresolved comments still need to be handled or addressed (feel free to disagree with me) and merge conflicts fixed (can be done by merging in develop from the main repo-- @micolspitale93 you might want to do this to your fork's develop first and then have changes from that develop merged to the current branch; up to you, feel free to ping me if you need assistance). Feel free to start discussion or message affected parties (can use git blame to see who last made changes to affected files/lines) if there's something difficult to handle in the conflicts. |
Adding the package harmoni home assistant to control the smart home devices. This package is a wrapper for the request to Home Assistant open source service: https://www.home-assistant.io/getting-started/