This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
Fixes #988 - Plugins with multiple config policy nodes may cause a panic #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay cause a panic
| c := New() | ||
| c.Add([]string{"intel", "foo", "sdi-x", "cody"}, d1) | ||
| c.Add([]string{"intel", "foo", "sdi-x", "nan"}, d2) | ||
| c.Freeze() |
There was a problem hiding this comment.
I believe Get calls freeze for you on the first get so I'm not sure this is needed.
edit: Was thinking of the wrong tree. Disregard.
|
LGTM |
IRCody
pushed a commit
to IRCody/snap
that referenced
this pull request
Jun 23, 2016
…cause a panic (intelsdi-x#989) * Fixes intelsdi-x#988 - Plugins with multiple config policy nodes may cause a panic * Test for intelsdi-x#988 - Plugins with multiple config policy nodes may cause a panic
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are multiple config policy nodes
and there exists a metric which does not fall under any of the policies
and the root node does not contain a policy
The following example causes a panic since no policies apply to
/intel/abc/baz.metric types
/intel/abc/foo
/intel/def/bar
/intel/abc/baz
config at
/intel/abc/foo
/intel/def/bar
root
/intel