medium tests for snap-collector-mock1

[katarzyna-z]

Summary of changes:

• Added medium tests for snap-collector-mock1

@intelsdi-x/snap-maintainers

[mbbroberg]

FYI - this will conflict with #944 and can be resolved pending the order of merges @intelsdi-x/snap-maintainers

[mbbroberg]

Hey @katarzyna-z - this looks great. Code overage is hitting the mark:

$ go test -tags=small -coverprofile=/tmp/coverage.out . && go tool cover -func=/tmp/coverage.out | grep -v '\t0.0%$'
ok      github.com/intelsdi-x/snap/plugin/collector/snap-collector-mock1    0.013s  coverage: 100.0% of statements
github.com/intelsdi-x/snap/plugin/collector/snap-collector-mock1/main.go:31:    main        100.0%
total:                                      (statements)    100.0%
$ cd mock/
$ go test -tags=small -coverprofile=/tmp/coverage.out . && go tool cover -func=/tmp/coverage.out | grep -v '\t0.0%$'
ok      github.com/intelsdi-x/snap/plugin/collector/snap-collector-mock1/mock   0.015s  coverage: 100.0% of statements
github.com/intelsdi-x/snap/plugin/collector/snap-collector-mock1/mock/mock.go:50:   CollectMetrics  100.0%
github.com/intelsdi-x/snap/plugin/collector/snap-collector-mock1/mock/mock.go:82:   GetMetricTypes  100.0%
github.com/intelsdi-x/snap/plugin/collector/snap-collector-mock1/mock/mock.go:99:   GetConfigPolicy 100.0%
github.com/intelsdi-x/snap/plugin/collector/snap-collector-mock1/mock/mock.go:111:  Meta        100.0%
github.com/intelsdi-x/snap/plugin/collector/snap-collector-mock1/mock/mock.go:125:  randInt     100.0%
total:                                          (statements)    100.0%

The only catch for our definition of small is that tests cover other packages. Like those in TestGetMetricTypes, also cover methods in node and core. I believe the goal of small tests would be to use nothing from other packages while you test a given method. Did I get that right @tjmcs?

[tjmcs]

The fact that these other Snap packages are being imported hints at this not being a true small test (since it relies on functionality from these other packages); ideally the calls to the functions or methods in these other packages should be mocked if this really is a set of small tests.

[marcin-krolik]

I don't agree with this approach. What is the point of mocking github.com/intelsdi-x/snap/core/ctypes, when I just need ctypes.ConfigValue for my test?

[geauxvirtual]

Disregard, forgot this is a plugin in snap repo.

[katarzyna-z]

I renamed the tests to "medium".

@intelsdi-x/snap-maintainers

[tjmcs]

LGTM, @katarzyna-z

[katarzyna-z]

@intelsdi-x/snap-maintainers Can this pull request be merged?

[pittma]

LGTM too. Merging.