Fixes #833 Move plugin-config outside of tribe cmds

[IRCody]

Fixes #833

Summary of changes:

• Moved plugin-config command underneath the plugin command so the syntax will go from snapctl plugin-config get ... to snapctl plugin config get ...
• It will now be available outside of tribe mode.

Testing done:

• Manual

@intelsdi-x/snap-maintainers

Move the plugin-config command in snapctl outside of tribe commands so
that it can be used when not in tribe mode. The new command will be
underneath the plugin set of commands in snapctl for consistency.

[candysmurf]

should you use global-plugin-config as the name or something to make it clear to users that it only lists the global plugin config?

[IRCody]

I don't think so. What other configs are there where the target is a plugin?

[candysmurf]

That's fine as it has plugin in the front of the command and is consistent with others. Also this command only shows the global config. Do I understand this correctly?

[IRCody]

I'm not sure I see how showing anything else would make sense. It's displaying the output from /v1/plugins/:type/:name/:version/config rest call. Are there other config values that would make sense to show for a plugin?

[candysmurf]

I thought we can define plugin specific config inside task manifest although that's task specific. If answer is yes, how that will have effect on the global plugin config. This topic may not related to your fix.

[candysmurf]

your fix is good! LGTM 👍

[IRCody]

You can put plugin specific stuff inside task manifest but I think that would fall under task config. Maybe there should be a way to see that like: snapctl task config <task-id>?

[candysmurf]

a nice doc for the current state and the future state, that would be nice. It has nothing to do with your fix here. I'm just trying to understand it. thanks.