This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
SDI-818: Restart failed plugins #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to rebase. |
candysmurf
force-pushed
the
sdi-818-jc
branch
from
3574d54 to
983f54d
Compare
jcooklin
force-pushed
the
sdi-818-jc
branch
2 times, most recently
from
076db64 to
6a11381
Compare
candysmurf
force-pushed
the
sdi-818-jc
branch
from
6a11381 to
408e55a
Compare
candysmurf
force-pushed
the
sdi-818-jc
branch
4 times, most recently
from
3f7c3f0 to
697339b
Compare
jcooklin
force-pushed
the
sdi-818-jc
branch
3 times, most recently
from
a20eaa4 to
8359a3b
Compare
|
|
||
| if pool.Eligible() { | ||
| if pool.RestartCount() < MaxPluginRestartCount { | ||
| e := r.restartPlugin(v.Key) |
There was a problem hiding this comment.
Let's add a log statement (warn) that we restarted plugin (name:version) x times.
There was a problem hiding this comment.
Add the warn log. please check. thanks
|
LGTM, after adding warn statement when restarting and rebasing. |
candysmurf
force-pushed
the
sdi-818-jc
branch
4 times, most recently
from
64fc7d5 to
24edb3a
Compare
jcooklin
added a commit
that referenced
this pull request
Feb 18, 2016
SDI-818: Restart failed plugins
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #497.