This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
SDI-98 #61
Merged
SDI-98 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e.Time). Easier to do operations on the time struct.
* Fixes to plugin * Fixes to mismapped RPC calls and broken reply structs * Renamed Collect to CollectMetrics to match GetMettricTypes * Added a proxy object to make RPC wrapping cleaner * broke up control/plugin package to be easier to find objects
Conflicts: control/control.go control/metrics.go core/metric.go
…r nil metrictype from catalog
and some workflow for router to available plugin pool
Conflicts: schedule/schedule.go schedule/work_manager_test.go
| } | ||
|
|
||
| func (a *availablePluginPool) Add(ap *availablePlugin) { | ||
| a.mutex.Lock() |
There was a problem hiding this comment.
a.Lock()
a.Unlock() to follow the pattern we've been using
|
Reminder: this PR is not ready for merge. It is awaiting refactoring by @danielscottt and @jcooklin. Comments of course should continue. |
| Plugin *loadedPlugin | ||
| namespace []string | ||
| lastAdvertisedTime time.Time | ||
| subscriptions int |
There was a problem hiding this comment.
+1 on uint -- There are lots of places that this needs to be done. @geauxvirtual has also pointed this out.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for refactor by @danielscottt and @jcooklin