This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
Fix for issue #328 pulse mgmt rest client does not properly return or… #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… throw an error when a directory is passed to LoadPlugin
|
Looking at the travis output, it looks like the change to use stat first before open throws a different error for this test. https://github.com/sandlbn/pulse/blob/master/mgmt/rest/client/client_func_test.go#L98 |
|
'll fix that later today. |
|
All passed, error was only in the name of the function. |
|
LGTM |
|
Fixes #328 |
pittma
added a commit
that referenced
this pull request
Sep 8, 2015
Fix for issue #328 pulse mgmt rest client does not properly return or…
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… throw an error when a directory is passed to LoadPlugin