Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

Fix publisher / processor unloading #1683

Merged
merged 1 commit into from
Jul 17, 2017
Merged

Fix publisher / processor unloading #1683

merged 1 commit into from
Jul 17, 2017

Conversation

mkleina
Copy link

@mkleina mkleina commented Jul 12, 2017

Fixes #1676 #1659

Summary of changes:

  • findLatestPool() now returns latest pool with at least 1 plugin assigned, empty pools are skipped
  • Plugin version for processors and publishers is resolved during subscription processing, if not provided in task manifest

Testing done:

  • Manual testing
  • Unit test

Task fails now after unloading all versions of used publisher / processor, unloading single version causes switching to another (latest one)

@intelsdi-x/snap-maintainers

@mkleina mkleina changed the title Fix pub subs Fix publisher / processor unloading Jul 12, 2017
marcintao
marcintao reviewed Jul 13, 2017
View reviewed changes
Copy link
Contributor

@marcintao marcintao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkleina
Copy link
Author

mkleina commented Jul 13, 2017

@marcintao Thanks! I squashed changes to single commit.

@mkleina mkleina merged commit 359a98b into intelsdi-x:master Jul 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marcintao marcintao marcintao left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SubscriptionGroup does not provide the version of subscribed publisher and processor plugins
2 participants
@mkleina @marcintao