Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

Fixed #1649 - incremented interval for tested task to 20ms #1670

Merged
merged 1 commit into from
Jun 19, 2017

Conversation

IzabellaRaulin
Copy link
Contributor

Fixes #1649

Summary of changes:

  • incrementing interval used in tests from 10ms to 20ms

Reasoning:

  • I observed that on Travis max relative error of firing task in interval equals +10.2541 ms (in observed samples), so interval =10 ms caused that sometimes received misses_count were greater than expected).

Solution:

  • increase used the interval to 20ms, so tests still will be executed quickly, but the probability of having a greater delay than determined interval has been minimized,

Testing done:

  • medium tests

@intelsdi-x/snap-maintainers

Copy link
Contributor

@andrzej-k andrzej-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrzej-k andrzej-k merged commit ed43eb6 into intelsdi-x:master Jun 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants