Schedule workflow execution immediately #1544
Conversation
IzabellaRaulin
changed the title
| last = time.Now() | ||
| r = append(r, r1) | ||
| } | ||
| // we should have either 21 or 23 minus 0 missed |
There was a problem hiding this comment.
"We should have either 21 or 23?", is an odd/inaccurate comment given we are checking for a value between 20 and 22. It should probably read, "we expect a range between x and y".
Also, this test is flaky >50% of the time on my system.
There was a problem hiding this comment.
Yes, I see. I changed the comment through all tests to be more appropriate. Now for each of tests cases, window-width is 200ms, so for interval 10ms it is expected to get in a range 19 - 22 responses (or 15-18 for tests when there are some missed responses).
@jcooklin, could you run those tests on your system to confirm that?
There was a problem hiding this comment.
100 of 100 runs were successful!
| @@ -50,26 +94,28 @@ func TestWindowedSchedule(t *testing.T) { | |||
| time.Sleep(w.Interval * 2) | |||
| } | |||
| } | |||
| // we should have either 16 or 17 minus 3 missed | |||
| So(len(r), ShouldBeBetweenOrEqual, 15, 17) | |||
| // we should have either 17 or 19 minus 4 missed | |||
There was a problem hiding this comment.
The comment should read, "We should have results between x and y".
This test comes back with 15 around 10% of the time for me.
There was a problem hiding this comment.
For the test with 4 missed responses, the range has been changed to 15 -18.
Notice that for a test without missed responses, 19- 22 responses are expected to receive.
| @@ -100,14 +147,23 @@ func TestWindowedSchedule(t *testing.T) { | |||
| time.Sleep(w.Interval * 2) | |||
| } | |||
| } | |||
| // we should have either 16 or 17 minus 3 missed | |||
| So(len(r), ShouldBeBetweenOrEqual, 10, 12) | |||
| // we should have either 12 or 14 results minus 4 missed | |||
There was a problem hiding this comment.
"Should have between 12 and 14 results"
There was a problem hiding this comment.
windowed width has been changed to 200ms to be more corresponding to the other tests-cases.
- applicable for simple and windowed schedule, not applicable for cron shedule
IzabellaRaulin
force-pushed
the
task_starts_immediately_rebased
branch
from
b8b22d5 to
9677fd5
Compare
ghost
mentioned this pull request
Related to #985
This PR is a part of the work being planned related to a single run task.
Before:
After:
Summary of changes:
task.Spin()(see scheduler/task.go#255), so for the first run lastFireTime equals time.Time{}Testing done:
@intelsdi-x/snap-maintainers