This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
Fixes #1521: Snaptel hang on task watch #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgmt/rest/client/task.go
Outdated
| @@ -93,6 +93,9 @@ func (c *Client) CreateTask(s *Schedule, wf *wmap.WorkflowMap, name string, dead | |||
| // interactive with Event and Done channels. An HTTP GET request retrieves tasks. | |||
| // StreamedTaskEvent returns if it succeeds. Otherwise, an error is returned. | |||
| func (c *Client) WatchTask(id string) *WatchTasksResult { | |||
| // during watch we don't want to have a timeout | |||
| c.http.Timeout = time.Duration(0) | |||
|
|
|||
There was a problem hiding this comment.
Calling task watcher causes overwrite client timeout to 0 for ever. Maybe the timeout should be set to its real value (set by user) after finish task watch - what do you think about that?
There was a problem hiding this comment.
That is a good point. In the context of this fix I was thinking of the only user as snaptel which wouldn't be affected by this.
Removes the timeout from the rest client when using task watch. Because the timeout isn't reset on each transfer of data having a timeout causes the watch to eventually hang when set.
|
I updated to address @IzabellaRaulin comment if @jcooklin or anyone wants to look at this again really click. Only 2 additional lines to save the old timeout and then change it back to the old timeout when we are done watching. |
|
LGTM 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1521
Summary of changes:
Removes the timeout from the rest client when using task watch. Because
the timeout isn't reset on each transfer of data having a timeout
causes the watch to eventually hang when set.
Testing done:
Would be interested in @mkleina verifying the fix works for them also.
@intelsdi-x/snap-maintainers