This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
Adds IdleConnTimeout to transport in client #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With Go 1.8 coming very soon, it's a good time for dev to switch to 1.7.3. |
candysmurf
suggested changes
Nov 17, 2016
| @@ -104,9 +105,11 @@ func Username(u string) metaOp { | |||
| var ( | |||
| secureTransport = &http.Transport{ | |||
| TLSClientConfig: &tls.Config{InsecureSkipVerify: false}, | |||
| IdleConnTimeout: time.Second, | |||
There was a problem hiding this comment.
do you like to make this option configurable?
There was a problem hiding this comment.
Not really. What scenario do you see where it would be beneficial for a user to configure this?
|
Can you drop the go 1.6.x test matrix in .travis.yml, and bump to go 1.7.3 so this can be considered for merging? |
IRCody
force-pushed
the
transport
branch
3 times, most recently
from
fa804c9 to
65e0449
Compare
candysmurf
approved these changes
Nov 18, 2016
|
@IRCody, please rebase. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of the discussion from #1324. These changes require go1.7+ and I wanted to move the discussion around which go versions to support instead of blocking that PR.
Summary of changes:
@intelsdi-x/snap-maintainers