This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
(SDI-2036) Fix #1205 add darwin to binary release #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanliu
force-pushed
the
release
branch
2 times, most recently
from
ce090da to
19266fa
Compare
IRCody
suggested changes
Sep 27, 2016
| "time" | ||
|
|
||
| "github.com/intelsdi-x/snap/core" | ||
| "github.com/intelsdi-x/snap/core/cdata" | ||
| "github.com/intelsdi-x/snap/plugin/helper" | ||
| ) | ||
|
|
||
| var ( | ||
| PluginName = "snap-plugin-collector-mock2" | ||
| SnapPath = os.ExpandEnv(os.Getenv("SNAP_PATH")) |
There was a problem hiding this comment.
| @@ -46,11 +47,11 @@ var ( | |||
| LOG_LEVEL = log.FatalLevel | |||
|
|
|||
| SNAP_PATH = os.ExpandEnv(os.Getenv("SNAP_PATH")) | |||
There was a problem hiding this comment.
Same thing here -- Do we need SNAP_PATH if all file paths are going through helper?
There was a problem hiding this comment.
This one can be removed.
| SNAP_AUTODISCOVER_PATH = fmt.Sprintf("%s/plugin", SNAP_PATH) | ||
| log.Warning(fmt.Sprintf("SNAP_AUTODISCOVER_PATH has been set to SNAP_PATH/plugin (%s). This might cause test failures", SNAP_AUTODISCOVER_PATH)) | ||
|
|
||
| SNAP_PATH = helper.BuildPath |
There was a problem hiding this comment.
This seems redundant since SNAP_PATH is set to helper.BuildPath at the top of the file.
| @@ -1,7 +1,7 @@ | |||
| /* | |||
| http://www.apache.org/licenses/LICENSE-2.0.txt | |||
|
|
|||
|
|
|||
| ld | |||
There was a problem hiding this comment.
err, yeah needs to be removed.
Currently we only build linux binaries. This update uses GOOS/GOARCH to
crosscompile for MacOS.
* remove dns update since we have multiple binaries
* follow s3/${GOOS}/${GOARCH}/file convention
* use helper.PluginFilePath to determine binary path
* change latest folder -> last git tag, latest_build folder -> last pr
| @@ -11,15 +11,14 @@ env: | |||
| global: | |||
| - SNAP_SOURCE=/home/travis/gopath/src/github.com/intelsdi-x/snap | |||
| - GO15VENDOREXPERIMENT=1 | |||
| - secure: kSsbBOCrSRyWx6yhSwhTYIWRId4WNMkO9OhMphBPXb5kDEd+asanCybuBKdOSgzuqrzBbQsuQjzhw+iZwdiPoQInZyDxeVl7frroNvg94n+q4tpPQOPzJ6gN15MCHSq3m1lCk3XVrESGEBTqmdmUtZhY+RfxSXuq1xkDMesst2f+gONd5Bl+QFiboRqvjUXwGC+e3JnZI2LxWjYZspNh2ZS6c5mvbhufDPV5MD6+jlZppzHcNkHAtHOt3KNoTFai8X0U8MYiEax3mSIAHjYzQQayS5al54MfgcVo1r4gWmPOybkyb5+/DyNSUT4KY+XVIrxV68fSOuCnLxLEaQZ9W0c0WuetmUU1fOT8Iy9q0qLQq9IknXNnfsCEGdwB2XKfyNvKEtkWbi6b6idrok5d1y7b8Qt5olveczGx0cRbpXQ0BTZ/bnQMhL9tpUeRltbDey6dsSsTJjnatqH7CdeEAV0ZeY+LjBgTukps4TlEHTn0ddEzhR1rrRsQ3OB0kT59Y3BCJ4kstzpMsTFWKUTMr/75UR1g5XETfOt0BtXkM3I343AIjJt+MQg/bW26ZOTbqPbqVO3Z7eDf0MaRC4Mugm809ekMZARTLAmq4FMIutDsTTT741IgWZQrMDI37WUztDUE1WFDzcTkAk99yc6gBjZ+0dZd1Qc7RQR0RMBi4M4= | |||
There was a problem hiding this comment.
What was this one used for?
There was a problem hiding this comment.
dns updates to point latest to the linux binary. it's no longer used.
IRCody
approved these changes
Oct 5, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we only build linux binaries. This update uses GOOS/GOARCH to
crosscompile for MacOS.