Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

Adds bool type to grpc Metric data #1168

Merged
merged 1 commit into from
Aug 30, 2016
Merged

Adds bool type to grpc Metric data #1168

merged 1 commit into from
Aug 30, 2016

Conversation

IRCody
Copy link
Contributor

@IRCody IRCody commented Aug 30, 2016

Summary of changes:

  • Adds bool type to grpc metric data, whether thats communicating with the plugin or over grpc to other snapd instances.
  • Change panic from unsupported type to log as an error instead.

Testing done:

  • manual testing with bool metric data
  • make test-{small, medium, legacy}

@intelsdi-x/snap-maintainers

@IRCody IRCody mentioned this pull request Aug 30, 2016
Merged
candysmurf
candysmurf reviewed Aug 30, 2016
View reviewed changes
control/plugin/client/grpc.go
case nil:
cm.Data = nil
default:
panic(fmt.Sprintf("unsupported type: %s", t))
log.Error(fmt.Sprintf("unsupported type: %s", t))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice change!

@candysmurf
Copy link
Contributor

💯 , LGTM

@candysmurf candysmurf merged commit 7f115d5 into intelsdi-x:master Aug 30, 2016
@IRCody IRCody deleted the add_bool_type branch October 11, 2016 17:35
@IRCody IRCody restored the add_bool_type branch October 11, 2016 17:35
@IRCody IRCody deleted the add_bool_type branch October 11, 2016 17:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IRCody @candysmurf