This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
Eliminates plugin log file #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // simpleFormatter is a logrus formatter that includes only the message. | ||
| type simpleFormatter struct{} | ||
|
|
||
| func (_ *simpleFormatter) Format(entry *log.Entry) ([]byte, error) { |
There was a problem hiding this comment.
I don't think you need the _.
|
Do you mind to resolve the branch conflicts? |
A plugins stdout and stderr are already captured by snapd and logged to snapd's log file. This commit removes the log file created by the client lib that captures much of the boiler plate interaction between control and the plugin including including logging heart beats, which RPC methods were invoked, etc. - Removes PluginLogPath from args sent to a plugin - Adds LogLevel to args sent to a plugin - Replaces log with logrus in legacy client lib
- adds vendor and glide.lock
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1102
A plugins stdout and stderr are already captured by snapd and logged
to snapd's log file. This commit removes the log file created by the
client lib that captures much of the boiler plate interaction between
control and the plugin including including logging heart beats, which
RPC methods were invoked, etc.
Summary of changes:
Testing done:
@intelsdi-x/snap-maintainers