This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
Fixes #1075 - FetchMetrics doesn't return latest metric(s) when version < 0 #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etric when version is < 0
jcooklin
changed the title
| @@ -81,17 +81,6 @@ func (s *Server) getMetricsFromTree(w http.ResponseWriter, r *http.Request, para | |||
| return | |||
| } | |||
|
|
|||
| // If no version was given, get all that fall at this namespace. | |||
There was a problem hiding this comment.
Removing this block of code no longer returns metrics from the rest server when using curl http://localhost:8181/v1/metrics/intel/mock/foo and now returns a 400 for invalid syntax instead of versions 1 and 2 of the metric.
There was a problem hiding this comment.
Good point, I was looking at it from the POV of the client.
|
LGTM |
This was referenced Jul 16, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1075
This PR was submitted in response to PR #1049 and comments made by @tjmcs. After this PR lands #1049 can land.
Summary of changes:
Testing done:
@intelsdi-x/snap-maintainers