Update snap build scripts #1027
Conversation
nanliu
commented
Jun 24, 2016
•
nanliu
commented
- make SNAP_PATH optional.
- remove options around build-plugins.
- fix docker test so it works regardless of directory.
- simplify travis.ci config.
nanliu
force-pushed
the
scripts
branch
5 times, most recently
from
9399ef1 to
a1854e0
Compare
| _debug "script directory ${__dir}" | ||
| _debug "project directory ${__proj_dir}" | ||
|
|
||
| [[ "$SNAP_TEST_TYPE" =~ ^(small|medium|large|legacy)$ ]] || _error "invalid TEST_TYPE (value must be 'small', 'medium', 'large', or 'legacy', recieved:${SNAP_TEST_TYPE}" |
There was a problem hiding this comment.
Probably should say "Invalid SNAP_TEST_TYPE", though should a different error be thrown if SNAP_TEST_TYPE is not set?
And at the end of the line, recieved -> received.
|
@geauxvirtual updated error message per request. |
|
When running tests, seeing this in the output. A message is displayed goimports is not found. It doesn't stop from running other commands, not sure if we want that behavior though. |
|
|
||
| _goimports() { | ||
| _go_get golang.org/x/tools/cmd/goimports | ||
| test -z "$(goimports -l -d $(find . -type f -name '*.go' -not -path "./vendor/*") | tee /dev/stderr)" |
There was a problem hiding this comment.
Should probably prefix any tool that is grabbed via go get with $GOPATH/bin so the tool can be run.
There was a problem hiding this comment.
Updated the test script to verify the path at the start, so we don't need to check the path later on per command. Also seems like our current test is missing folders since gofmt didn't catch errors in plugins dir.
nanliu
force-pushed
the
scripts
branch
3 times, most recently
from
504a798 to
9e9ee44
Compare
| glide) | ||
| _go_get github.com/Masterminds/glide | ||
| ;; | ||
| govendor) |
There was a problem hiding this comment.
Only other comment I have would be to remove glide and govendor from install_go_dep and restore_go_dep and reintroduce glide with the other PR.
There was a problem hiding this comment.
sure, that's all cleanup and removed now.
nanliu
force-pushed
the
scripts
branch
2 times, most recently
from
fbc525c to
7e09842
Compare
* make SNAP_PATH optional. * remove options around build-plugins. * use test as branch name when checking out git ref. * fix docker test so it works regardless of directory. * simplify travis.ci config.
|
+1 Per discussion with Justin |
* gofmt is asleep at the wheel in current test. * Update snap build scripts * make SNAP_PATH optional. * remove options around build-plugins. * use test as branch name when checking out git ref. * fix docker test so it works regardless of directory. * simplify travis.ci config. * Make sure gopath and path configured correctly.
