Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

Incorrect global flags for snapctl #701

Closed
geauxvirtual opened this issue Feb 5, 2016 · 0 comments
Closed

Incorrect global flags for snapctl #701

geauxvirtual opened this issue Feb 5, 2016 · 0 comments

Comments

@geauxvirtual
Copy link
Contributor

The help for snapctl lists global flags for url and apiversion as having two options:
--url or -u and --api-version or -a. However, neither -u or -a actually work because the code in cmd/snapctl/main.go is checking for --u and --a. Single letter options should only need a single dash in front of them.

https://github.com/intelsdi-x/snap/blob/master/cmd/snapctl/main.go#L67-L78

It could be argued that passing --a or --u should throw an error for an invalid flag instead of just ignoring the flag.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants