This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 294
Plugins should be unsubscribed by the event handler after the task state is Stopped #1601
Comments
rashmigottipati
added a commit
to rashmigottipati/snap
that referenced
this issue
Apr 12, 2017
rashmigottipati
added a commit
to rashmigottipati/snap
that referenced
this issue
Apr 13, 2017
rashmigottipati
added a commit
to rashmigottipati/snap
that referenced
this issue
Apr 13, 2017
rashmigottipati
added a commit
to rashmigottipati/snap
that referenced
this issue
Apr 13, 2017
rashmigottipati
added a commit
to rashmigottipati/snap
that referenced
this issue
Apr 13, 2017
rashmigottipati
added a commit
to rashmigottipati/snap
that referenced
this issue
Apr 13, 2017
rashmigottipati
added a commit
to rashmigottipati/snap
that referenced
this issue
Apr 13, 2017
rashmigottipati
added a commit
to rashmigottipati/snap
that referenced
this issue
Apr 13, 2017
rashmigottipati
added a commit
to rashmigottipati/snap
that referenced
this issue
Apr 13, 2017
rashmigottipati
added a commit
to rashmigottipati/snap
that referenced
this issue
Apr 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Current behavior:
When a stop task request is processed by the scheduler, it immediately starts unsubscribing all dependencies (plugins) of this task. This results in the plugins being used by the current firing of the workflow being killed.
Desired behavior:
Plugins should be unsubscribed after the task state is changed to Stopped state. There is an intermediate state between firing and stopped (i.e. Stopping). When the task state is changed to stopping, we close the channel "killchan" and closing of this killchan is received in the spin go routine. Changing of task state from stopping to stopped takes place here. So, plugins should be unsubscribed:
The text was updated successfully, but these errors were encountered: