Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

snapctl printing "If the number of maximum failures is not specified, use default value of x" #1131

Closed
IRCody opened this issue Aug 8, 2016 · 1 comment · Fixed by #1127

Comments

@IRCody
Copy link
Contributor

IRCody commented Aug 8, 2016

When starting a task without the maximum number of failures, snapctl will print out the following:

% ./snapctl task create -t task.json  
Using task manifest to create task
If the number of maximum failures is not specified, use default value of 10

this feels like an odd place to be printing this out and is phrased somewhat oddly. If we want to inform the user of what we are doing it could be phrased like:

No value provided for maximum failures, using default value of 10

To more clearly state what is happening, rather than putting it as a conditional (which is only printed in the case where the # of max failures is not specified).

Relevant code is here.

@tjmcs
Copy link
Contributor

tjmcs commented Aug 8, 2016

This is addressed as part of PR #1127, which is currently still open but close to being merged. When that PR is merged, this issue should be closed as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants